Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get assigned entity channels qb #2790

Conversation

monrostar
Copy link
Contributor

Description

This fisk is necessary because typeorm does not remove the original table from the from query when creating the qb. In order to do this it was necessary to use manager.

Now a SQL request looking like this

‌SELECT "channel"."channelId" AS "channelId" FROM "public"."product_channels_channel" "channel" WHERE "channel"."productId" = $1

Prev:

SELECT "channel"."channelId" AS "channelId" FROM "public"."asset" "Asset", "public"."asset_channels_channel" "channel" WHERE "channel"."assetId" = $1

Breaking changes

Does this PR include any breaking changes we should be aware of?

  • no

Screenshots

telegram-cloud-photo-size-2-5258359367533714224-y

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@monrostar monrostar closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant